AIP-38 feat: add Korean language UI#50981
Conversation
choo121600
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
|
Would you consider yourself or somebody else adding to CODEOWNER to maintain Korean translations? |
|
Yes, I’m interested in being added as a CODEOWNER to help maintain the Korean translations 🙌 |
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM from a functional point of view.
Can't vouch for the translation unfortunately.
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Just one merge cross-conflict, otherwise good to merge in my view.
the CODEOWNER - sorry was shooting too fast - we need to clarify later.
Note that translation need to be updated once we start also adding i18n support to other dialogs - could you contribute there as well?
Of course. I'm happy to help wherever I can ;) |
* feat: add Korean language UI * Add Korean translation code owner * Remove Korean translation code owner * Add German option to Korean
* feat: add Korean language UI * Add Korean translation code owner * Remove Korean translation code owner * Add German option to Korean
3 participants
Follow up to #50626 & #50863 - added Korean UI string translations.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.